This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Added support for Azures Client secret#25
Open
Cuddliness wants to merge 2 commits intoGeyserMC:masterfrom
Open
Added support for Azures Client secret#25Cuddliness wants to merge 2 commits intoGeyserMC:masterfrom
Cuddliness wants to merge 2 commits intoGeyserMC:masterfrom
Conversation
rtm516
suggested changes
May 27, 2022
src/main/java/com/github/steveice10/mc/auth/service/MsaAuthenticationService.java
Outdated
Show resolved
Hide resolved
Author
|
Pushed new code where the client_secret is optional, Maded changes on each request that can use a client_secret, the requests will only include a client_secret when this is set. MsaAuthenticationService service = new MsaAuthenticationService("<clientID>");
service.setClientSecret("<secret>");
service.login();PS: it's my first ever contribution so i appricate the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since i was not able to get a refresh token anymore, due the need of a client_secret. I added the support for that :).
Why?
I was not able to login with a refresh token, since it asked for a client_secret.
MsaAuthenticationService service = new MsaAuthenticationService("AzureID", "AzureSecret");