Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Added support for Azures Client secret#25

Open
Cuddliness wants to merge 2 commits intoGeyserMC:masterfrom
Cuddliness:master
Open

Added support for Azures Client secret#25
Cuddliness wants to merge 2 commits intoGeyserMC:masterfrom
Cuddliness:master

Conversation

@Cuddliness
Copy link

@Cuddliness Cuddliness commented May 26, 2022

Since i was not able to get a refresh token anymore, due the need of a client_secret. I added the support for that :).

Why?

I was not able to login with a refresh token, since it asked for a client_secret.

MsaAuthenticationService service = new MsaAuthenticationService("AzureID", "AzureSecret");

@Cuddliness
Copy link
Author

Pushed new code where the client_secret is optional,

Maded changes on each request that can use a client_secret, the requests will only include a client_secret when this is set.
As stated above you can now use it as:

MsaAuthenticationService service = new MsaAuthenticationService("<clientID>");
            service.setClientSecret("<secret>");
            service.login();

PS: it's my first ever contribution so i appricate the feedback!
Let me know if something can be diffrent / better!

@Cuddliness Cuddliness marked this pull request as draft May 27, 2022 16:44
@Cuddliness Cuddliness marked this pull request as ready for review May 27, 2022 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants