UI: Fix VNF NIC mapping network select always disabled#1
Open
Gia-Bursulaia wants to merge 1 commit into
Open
Conversation
Remove incorrect disabled attribute from VnfNicsSelection.vue. The attribute was a plain string instead of Vue binding, causing the select to always be disabled regardless of state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove incorrect disabled attribute from VnfNicsSelection.vue. The attribute was a plain string instead of Vue binding, causing the select to always be disabled regardless of state.
Description
Fixes VNF NIC mapping network select dropdown which was permanently disabled.
The disabled attribute was written as a plain HTML string instead of a Vue reactive binding (missing : prefix). In Vue/Ant Design, any non-empty string is treated as truthy, making the select always disabled regardless of state.
Tested on CloudStack 4.22.1.0 with KVM hypervisor.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?