refactor(frontend): decouple wallet logic into useWalletManager hook#539
Open
Mosas2000 wants to merge 4 commits intoGildado:mainfrom
Open
refactor(frontend): decouple wallet logic into useWalletManager hook#539Mosas2000 wants to merge 4 commits intoGildado:mainfrom
Mosas2000 wants to merge 4 commits intoGildado:mainfrom
Conversation
|
@Mosas2000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Resolve conflict in WalletProvider.tsx by keeping the refactored useWalletManager hook approach while incorporating upstream accessibility improvements (modal title ID and aria attributes). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace 'any' type with properly typed MockKitInstance interface - Fix floating promises by properly awaiting async operations - Remove unused MockedFunction import - Use vi.mocked() for cleaner mock implementations Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have completed the refactoring of the useWallet hook logic as requested for this issue
I decoupled the wallet connection and state management into a clean, new custom hook called useWalletManager.ts, while stripping out the logic from WalletProvider.tsx so it acts only as a pure UI and context wrapper. I also identified and fixed a subtle memory leak in the timeout mechanism.
Fully automated tests were added for the new hook structure and they are passing reliably.
Closes #401