Skip to content

Create Intro to {gsm} slides#129

Draft
Jeremy Wildfire (jwildfire) wants to merge 7 commits into
devfrom
fix-128
Draft

Create Intro to {gsm} slides#129
Jeremy Wildfire (jwildfire) wants to merge 7 commits into
devfrom
fix-128

Conversation

@jwildfire
Copy link
Copy Markdown
Contributor

@jwildfire Jeremy Wildfire (jwildfire) commented Mar 10, 2026

Summary

  • add a new RevealJS article: Intro to {gsm} slides
  • add custom slide styling and theme picker include
  • add referenced slide image assets (business process, YAML, and sample report screenshots)
  • register the new article in pkgdown config

Closes #128

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 10, 2026

🌐 PR pkgdown deployed: https://Gilead-BioStats.github.io/gsm.core/pr/129/dev

Last updated: 2026-03-10T17:34:33.328Z

- Move IntroGsmSlides source to inst/slides/ so pkgdown doesn't re-render
- Pre-render RevealJS slides to pkgdown/extra/slides/
- Add Quarto setup and render step to workflow
- Update navbar to link to pre-rendered slides
@jonthegeek
Copy link
Copy Markdown
Contributor

FYI I set up a slides folder for the qcthat pkgdown. I intentionally didn't put them in inst, because that means they'll be installed with the package, and it makes more sense to render them as part of the pkgdown site. I can copy/paste that setup into this PR if you'd like.

@jwildfire
Copy link
Copy Markdown
Contributor Author

Jeremy Wildfire (jwildfire) commented Mar 10, 2026

FYI I set up a slides folder for the qcthat pkgdown. I intentionally didn't put them in inst, because that means they'll be installed with the package, and it makes more sense to render them as part of the pkgdown site. I can copy/paste that setup into this PR if you'd like.

Yeah, this is all messed up still. it was getting late and Copilot was slow. Thanks for the pointer to the qcthat slides - fixing now. Just prompted:

https://github.com/Gilead-BioStats/qcthat has an intro slide deck deployed in pkgdown. use the same approach in gsm.core. feel free to checkout the qcthat package locally if needed.

Which i suspect will do the trick.

@jonthegeek
Copy link
Copy Markdown
Contributor

Which i suspect will do the trick.

Almost, but it kept it in inst. It would probably work, but it's messier than my way of doing it. I'm sure it'll miss .Rbuildignore without extremely careful prompting.

@jonthegeek
Copy link
Copy Markdown
Contributor

Jeremy Wildfire (@jwildfire) Oh, importantly, this is targeting main, which I'm pretty sure you don't want to do. You can switch that with the edit pencil next to the title.

@jwildfire Jeremy Wildfire (jwildfire) changed the base branch from main to dev March 10, 2026 15:13
@jwildfire
Copy link
Copy Markdown
Contributor Author

Oh, importantly, this is targeting main, which I'm pretty sure you don't want to do. You can switch that with the edit pencil next to the title.

tnx. fixed.

@jonthegeek
Copy link
Copy Markdown
Contributor

This is still in a directory that gets installed by the user. I think it makes more sense to keep it outside of inst. I want to push back because my goal is to update gsm.utils to support this, and right now it would make me put them somewhere I don't want to put them in qcthat 🙃

@jwildfire
Copy link
Copy Markdown
Contributor Author

This is still in a directory that gets installed by the user. I think it makes more sense to keep it outside of inst. I want to push back because my goal is to update gsm.utils to support this, and right now it would make me put them somewhere I don't want to put them in qcthat 🙃

Yeah. I'll mark this draft until it's ready for review. Next iteration (between meetings) is to add support in gsm.utils for doing this via examples framework.

@jwildfire Jeremy Wildfire (jwildfire) marked this pull request as draft March 10, 2026 17:33
@jonthegeek
Copy link
Copy Markdown
Contributor

Examples framework (in inst) also installs with the package, but I think that's mostly fine. It makes less sense to me to bundle the slide deck in the package itself and not just the website (but honestly both probably COULD go outside inst and only show up on the website).

@jwildfire
Copy link
Copy Markdown
Contributor Author

Let's move this discussion over to gsm.utils and make needed updates there and then use this PR to pilot an update that supports slides/qmd rendering in addition to our current examples framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create "Intro to gsm slides"

2 participants