Add Classic Light mode and independent accent themes - #314
Draft
engelben wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
system | light | dark) from independent Pokémon accent palettes so users can choose brightness and accent independently.themepreference into the new accent storage safely.Description
useAppearance, exported also asuseTheme) that managescolorMode,resolvedColorMode,accent, persistence keyspokecollector-color-modeandpokecollector-accent, legacythememigration, liveprefers-color-schemetracking, and centralized DOM application. (frontend/src/hooks/useTheme.js)index.htmlthat resolves mode+accent and applies them on the document element before React renders to avoid theme flash. (frontend/index.html)data-theme) to avoid breaking third-party/custom styles. (frontend/src/main.jsx)Testing
git diff --checkto validate whitespace and patch issues and it returned clean results.cd frontend && npm ci && npm run buildand the production build completed successfully (Vite build completed).47 tests passedacross the suite).