Add ARM64 (AArch64) binary release archives for macOS and Windows#1479
Merged
Byron merged 4 commits intoGitoxideLabs:mainfrom Jul 30, 2024
Merged
Add ARM64 (AArch64) binary release archives for macOS and Windows#1479Byron merged 4 commits intoGitoxideLabs:mainfrom
Byron merged 4 commits intoGitoxideLabs:mainfrom
Conversation
They corresponded one-to-one, with `build` holding short names. But the short names were: - Not needed, not having appeared in releases. - Misleading, e.g. by not carrying an architecture, the short name `macos` may have obscured that a major architecture wasn't covered. - Limiting, in that short names are harder to come up with when more architectures on the same operating systems are built for, as will be done soon.
This should be broadly useful, but see GitoxideLabs#1478 for specific context.
5 tasks
Byron
approved these changes
Jul 30, 2024
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for all your help with this! Amazing work!
This was referenced Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #1478 (comment), this PR does some of the tasks for #1478. I believe this actually is a complete fix for that bug as described. But I suggest keeping the #1478 open and treating that issue more broadly, to encompass both this and other near-future changes. I've opened this PR now so that the core confusion can be avoided in the next release even if there are delays in doing the rest and even if the next release is sooner than anticipated.
Although I suggest scoping this to just those tasks, I'm willing to broaden this PR to include building universal binaries and just keep this PR open for a while until I can get that done. (But there may be some delays, even if nothing goes wrong, because I'm out of private runner minutes. That's probably a blessing in disguise, since this may not be the best way to work on this, even aside from that limitation. But it does mean I'll have to find another way to approach it.)
Details on the produced archives, analogous to the information there, can be see in this gist, which may make even the most important part more readable than it can be here, but here's that part:
As alluded to in the task list in #1478, this includes refactoring of the workflow to make architectures more explicit. See 076c262 on this and its rationale.