Model non-empty invariants across merge, shallow, ODB, and commitgraph#2432
Model non-empty invariants across merge, shallow, ODB, and commitgraph#2432
Conversation
a07ca4c to
191e148
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b97848e1f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tests/tools/src/lib.rs
Outdated
| let (force_run, script_result_directory) = | ||
| force_and_dir(destination_dir, root, &archive_name, hash_kind, &script_identity); |
There was a problem hiding this comment.
Include hash kind in Rust fixture archive key
This adds hash-kind namespacing to script_result_directory but still uses the same archives/rust-{name}.* file for all hash kinds, so a fixture generated once (e.g., SHA-1) can be extracted and reused for another hash kind (e.g., SHA-256) without re-running the closure because archive validation only checks script_identity and platform. In practice, running the same rust_fixture_* name/version across different hash kinds can silently serve stale/wrong fixture content and invalidate test results.
Useful? React with 👍 / 👎.
191e148 to
22af951
Compare
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
22af951 to
9245200
Compare
|
Very wrong. |
Summary
gix_revision::merge_base::Bases) and propagate this throughgixandgix-mergegix-shallowand adaptgix/gix-protocolcallersgix-mergegix-odbdynamic snapshot usagegix-commitgraphgitoxide-corehours estimation APITasks