Pull request to resolve issue #57 - Angular test file cli option#110
Pull request to resolve issue #57 - Angular test file cli option#110jackcoral89 wants to merge 10 commits intoGiuliano1993:mainfrom
Conversation
Giuliano1993
left a comment
There was a problem hiding this comment.
Hi @jackcoral89 first of all thx for your PR!
There's a couple of fix that needs to be addressed before I can merge this, you should see them in the review.
Briefly, at the moment, the question for a .spec file pops up also in non-angular components flow, while it shouldn't.
It also happens that for angular component the "create another component" question doesn't work anymore (it pops up but when I say yes it stops the execution anyway) , don't know if it's related to the flag fix or something else!
|
@Giuliano1993 fyi |
|
Yes @jackcoral89 I saw the update thanks. I was actually thinking of the best way to proceed since I noticed that your PR is based on an outdated version of MJC, the whole project structure has changed meanwhile, so I was trying to figure out the more convenient way to move from here to include your code in the project :) |
Added angular .spec file optional