ci: bump Go to stable, refresh actions to v5#3
Merged
Conversation
go.mod declares `go 1.25.5` but the workflow installed Go 1.20, which
errors on three-part version directives:
go: errors parsing go.mod:
/home/runner/work/gevm/gevm/go.mod:3: invalid go version '1.25.5':
must match format 1.23
Pin the workflow to Go `stable` (with check-latest so we pick up new
1.25.x patch releases). Also bump `actions/checkout` and
`actions/setup-go` to v5 so the runner's deprecation warning about
Node 20 goes away (v5 ships on Node 24).
Drop the `git submodule update --init --recursive` from the test step:
.gitmodules declares fixture submodules but the tree contains no
gitlink pointers, so the command was a silent no-op. Fixture-gated
tests already self-skip when their env vars (GEVM_TESTS_DIR / etc.)
are unset, which they are on stock CI.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Master CI has been failing since the merge of #2:
The workflow pinned
go-version: '1.20', butgo.moddeclaresgo 1.25.5. Go 1.20's parser only accepts two-part1.Xdirectives — three-part1.X.Ywas added in Go 1.21. Bump the workflow tostable(withcheck-latest: true).While here, refresh the actions to v5 (Node 24) — the workflow log was warning about Node 20 deprecation on
actions/checkout@v4andactions/setup-go@v4.Also drop the
git submodule update --init --recursivefrom the test step..gitmodulesdeclares two fixture submodules (tests/fixtures/ethereum-tests,tests/fixtures/execution-spec-tests) but neither has a gitlink pointer in the tree, sogit submodule update --initis a silent no-op on every CI run. The fixture-gated tests (TestSpecFixtureDir,TestBlockchainFixtureDir, etc.) already self-skip whenGEVM_TESTS_DIR/GEVM_BLOCKCHAIN_TESTS_DIR/ etc. are unset, which they are in stock CI.Test plan
🤖 Generated with Claude Code