fix: gRPC error extraction and About modal layout - #31
Closed
Gkrumbach07 wants to merge 1 commit into
Closed
Conversation
Rebase of #18 onto current main, dropping the obsolete CORS/ALLOWED_ORIGINS change (CORS was removed in #29). 1. gRPC error extraction: use errors.As with GRPCStatus() interface instead of status.FromError to get the clean gateway message from wrapped errors. Avoids grpc-go v1.82+ replacing the message with the full error chain. 2. About modal: use isAutoFit with autoFitMinModifier for responsive layout without mid-word label wrapping. Original-author: Gaizka Menendez Hernandez <gmenende@redhat.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased version of #18 onto current main, dropping the obsolete CORS change (removed in #29).
errors.AswithGRPCStatus()interface instead ofstatus.FromErrorto get the clean gateway message from wrapped errors (avoids grpc-go v1.82+ full error chain in messages)isAutoFitwithautoFitMinModifierfor responsive layout without mid-word label wrappingSupersedes #18 (cross-repo, can't rebase).
Original author: @gmenher
Test plan
go build ./...go test ./internal/api/ -run TestWriteGrpcError— all 6 wrapped error cases passgo vet ./...tsc --noEmit🤖 Generated with Claude Code