Skip to content

Mirror the air-conditioning fan speed and swing feature types - #10

Open
Terdious wants to merge 1 commit into
GladysAssistant:mainfrom
Terdious:feat/ac-extended-feature-types
Open

Mirror the air-conditioning fan speed and swing feature types#10
Terdious wants to merge 1 commit into
GladysAssistant:mainfrom
Terdious:feat/ac-extended-feature-types

Conversation

@Terdious

@Terdious Terdious commented Jul 21, 2026

Copy link
Copy Markdown

Mirror of the Gladys core addition (air-conditioning FAN_SPEED, SWING_HORIZONTAL and SWING_VERTICAL feature types) in the device constants and the TypeScript typings, so integrations can declare the full control surface of an AC unit. Companion of the core PR extracted from the Tuya air-conditioner work (#2591).

Summary by CodeRabbit

  • New Features
    • Added support for air-conditioning fan speed control.
    • Added support for horizontal and vertical swing controls.
    • Updated type definitions to expose the new feature options.

Mirror of the Gladys core addition (air-conditioning FAN_SPEED,
SWING_HORIZONTAL and SWING_VERTICAL feature types) in the device constants
and the TypeScript typings, so integrations can declare the full control
surface of an AC unit. Companion of the core PR extracted from the Tuya
air-conditioner work (#2591).
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0265ee8d-3a02-4aa3-bade-73838ff9499c

📥 Commits

Reviewing files that changed from the base of the PR and between 55c34f1 and e928484.

📒 Files selected for processing (2)
  • index.d.ts
  • lib/device-constants.js

📝 Walkthrough

Walkthrough

The air conditioning feature map and its TypeScript declarations now support fan speed, horizontal swing, and vertical swing feature keys.

Changes

Air conditioning features

Layer / File(s) Summary
Add feature constants and type declarations
lib/device-constants.js, index.d.ts
Adds FAN_SPEED, SWING_HORIZONTAL, and SWING_VERTICAL with matching discovery string values to the runtime mapping and exported declarations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: pierre-gilles

Poem

A bunny hops through cool machine,
Three new controls now join the scene.
Fan winds softly, swings align,
Left and right, then up in time.
“Hare-raising features!” I cheer,
Airy comfort’s blooming here.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the added air-conditioning fan speed and swing feature types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant