Add battery-storage device constants - gladys-zendure external - #6
Add battery-storage device constants - gladys-zendure external#6Terdious wants to merge 5 commits into
Conversation
Mirror of the solar-battery category added to Gladys core (GladysAssistant/Gladys#2682): solar-battery category with battery-level, battery-input-power and battery-output-power types, in lib/device-constants.js and index.d.ts, with test coverage. Needed by external integrations reporting solar battery telemetry, starting with the Zendure integration (Terdious/gladys-zendure). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012157sX3FKhVYmndWLJdhfo
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a ChangesBattery storage constants
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e category
Rename the SOLAR_BATTERY category to BATTERY_STORAGE ('battery-storage') and
expand its feature types to a full set of power/energy flow constants covering
charge/discharge, solar input, home output, grid import/export and off-grid,
mirroring the Gladys core. Update the TypeScript typings and tests accordingly.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012157sX3FKhVYmndWLJdhfo
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012157sX3FKhVYmndWLJdhfo
…/discharge-index Mirror of the core rename: `index` is the core's established vocabulary for a cumulative kWh meter reading, so the two battery-storage counters become charge-index / discharge-index. battery-energy-remaining is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012157sX3FKhVYmndWLJdhfo
cab59a1 to
588b603
Compare
Mirror the core reordering (GladysAssistant/Gladys#2682): place battery-storage next to the other battery categories (after battery-low) in both the JS constants and the TypeScript typings. Pure reordering, no behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mirror of the
battery-storagecategory added to Gladys core (GladysAssistant/Gladys#2682): thebattery-storagecategory withbattery-level,charge-power,discharge-power,charge-index,discharge-indexandbattery-energy-remainingtypes, in lib/device-constants.js and index.d.ts, with test coverage.Needed by external integrations reporting battery storage telemetry, starting with the Zendure integration (Terdious/gladys-zendure).
Claude-Session: https://claude.ai/code/session_012157sX3FKhVYmndWLJdhfo
Summary by CodeRabbit
battery-storagedevice feature category.battery-storagecategory and related feature-type identifiers.