Add energy-flow device feature constants (production power, grid-sensor, home-output-sensor) - #8
Open
Terdious wants to merge 3 commits into
Open
Conversation
Mirror of the core addition: energy-production-sensor gains a `power` type for the instantaneous production power (watt, >= 0) that solar inverters and hybrid storage systems report, alongside the existing cumulative/derived types. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012157sX3FKhVYmndWLJdhfo
📝 WalkthroughWalkthroughAdds grid and home-output sensor categories and feature types to runtime constants and TypeScript declarations, expands energy production types, and verifies the canonical string mappings with tests. ChangesEnergy feature constants
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012157sX3FKhVYmndWLJdhfo
… feat/energy-production-sensor-power
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors GladysAssistant/Gladys#2693 in the SDK constants so external integrations can expose the full energy-flow telemetry:
DEVICE_FEATURE_TYPES.ENERGY_PRODUCTION_SENSOR.POWER('power') — instantaneous production power in watt (live solar/production power);grid-sensorcategory —input-power,output-power, signedpower,input-index,output-index(the device's own grid exchange);home-output-sensorcategory —power,index,off-grid-power,off-grid-index(power delivered to the home / backup output).Added in
lib/device-constants.jsandindex.d.ts, with test coverage.Claude-Session: https://claude.ai/code/session_012157sX3FKhVYmndWLJdhfo
Summary by CodeRabbit
New Features
Tests