fix(cli): close live board rows on every exit path (#1347) - #1349
Closed
Jaro-c wants to merge 1 commit into
Closed
Conversation
Six call sites across `up` and `down` opened a board row with `progress::start` and never closed it on a code path that returned or fell through, so the row stayed on the working spinner forever even though the operation was over. The plain sink emitted nothing and the live board painted a frozen `Creating`/`Removing`/`Pulling` spinner. The container-create side of `up` already does this right — it closes with `"Exists"`, `"Running"` or `"Created"` before returning. The six sites missing the close are: | Command | File | Verb before | Verb after | |---------|-----------------------|-------------|-------------| | up | network/mod.rs | (stuck) | "Exists" | | up | volume/mod.rs | (stuck) | "Exists" | | up | build/pull.rs | (stuck) | "Failed" | | down | lifecycle/mod.rs | (stuck) | "Absent" / "Failed" | | down | lifecycle/mod.rs | (stuck) | "Absent" / "Failed" | | down | lifecycle/parallel.rs | (stuck) | "Absent" / "Failed" | Closing with an honest verb makes the failure arms in `down` visible: the genuine removal failure used to print as a tracing::warn and exit with the error, but the board kept painting `Removing` with a spinner, hiding which resource failed. The verb-banding now paints "Failed" red instead of green, and the row marker carries a red ✘ for verb = "Failed" (case-insensitive, failsafe to ✘ so a future caller using "failed" or "Failing" does not silently regress to the green ✔ of a successful row). The per-site fix is what the issue calls out; the structural fix (a guard returned by `start()` that force-closes on drop) is a separate concern worth its own issue — leaving the per-site pattern unchanged matches the existing `Exists`/`Running` precedent and fixes every observable from the bug report. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opened to retrigger CI workflows that were stuck in runner queue.
Original PR: #1348
Branch: fix/issue-1347-close-orphaned-board-rows
Signed-off-by: Jaro-c 75870284+Jaro-c@users.noreply.github.com