Merge and update latest changes from CrisisTextLine/modular fork

.github/copilot-instructions.md

@@ -29,6 +29,7 @@ This is the Modular Go framework - a structured way to create modular applicatio
 - **Module Development**: Follow the established module interface patterns and provide comprehensive configuration options
 
 ### Required Before Each Commit
+- The current implementation should always be considered the *real* implementation. Don't create placeholder comments, notes for the future, implement the real functionality *now*.
 - Format Go code with `gofmt`
 - Run `golangci-lint run` and fix any linting issues
 - Ensure all tests pass (core, modules, examples, and CLI):
@@ -162,4 +163,4 @@ Working example applications:
 ### Configuration Tools
 - Generate sample configs: `modular.SaveSampleConfig(cfg, "yaml", "config-sample.yaml")`
 - Support for YAML, JSON, and TOML formats
-- Automatic validation and default value application
+- Automatic validation and default value application

.github/workflows/ci.yml

@@ -34,6 +34,16 @@
           go test ./... -v
           go test -v -coverprofile=coverage.txt -covermode=atomic -json ./... >> report.json
 
+      - name: Run BDD tests explicitly
+        run: |
+          echo "Running core framework BDD tests..."
+          go test -v -run "TestApplicationLifecycle|TestConfigurationManagement" . || echo "Some core BDD tests may not be available"
+
+      - name: Verify BDD test coverage
+        run: |
+          chmod +x scripts/verify-bdd-tests.sh
+          ./scripts/verify-bdd-tests.sh
+
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v5
         with:
@@ -98,7 +108,43 @@
           npx github-actions-ctrf cli-report.ctrf.json
         if: always()
 
+  # Dedicated BDD test job for comprehensive BDD test coverage
+  bdd-tests:
+    name: BDD Tests
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: ${{ env.GO_VERSION }}
+          check-latest: true
+          cache: true
+
+      - name: Get dependencies
+        run: |
+          go mod download
+          go mod verify
+
+      - name: Run Core Framework BDD tests
+        run: |
+          echo "=== Running Core Framework BDD Tests ==="
+          go test -v -run "TestApplicationLifecycle|TestConfigurationManagement" . 
+
+      - name: Run Module BDD tests
+        run: |
+          echo "=== Running Module BDD Tests ==="
+          for module in modules/*/; do
+            if [ -f "$module/go.mod" ]; then
+              module_name=$(basename "$module")
+              echo "--- Testing BDD scenarios for $module_name ---"
+              cd "$module" && go test -v -run ".*BDD|.*Module" . && cd -
+            fi
+          done
+
   lint:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5

.github/workflows/examples-ci.yml

@@ -32,12 +32,8 @@ jobs:
           - testing-scenarios
           - observer-pattern
           - health-aware-reverse-proxy
-          - auth-demo
-          - cache-demo
-          - scheduler-demo
-          - eventbus-demo
-          - jsonschema-demo
-          - letsencrypt-demo
+          - multi-engine-eventbus
+          - logmasker-example
     steps:
       - name: Checkout code
         uses: actions/checkout@v5
@@ -285,104 +281,55 @@ jobs:
               exit 1
             fi
 
-          elif [ "${{ matrix.example }}" = "auth-demo" ]; then
-            # Auth demo needs to test authentication endpoints
-            timeout 10s ./example &
-            PID=$!
-            sleep 3
-
-            # Test health endpoint
-            if curl -f http://localhost:8080/health; then
-              echo "✅ auth-demo health check passed"
-            else
-              echo "❌ auth-demo health check failed"
-              kill $PID 2>/dev/null || true
-              exit 1
-            fi
-
-            kill $PID 2>/dev/null || true
-
-          elif [ "${{ matrix.example }}" = "cache-demo" ]; then
-            # Cache demo needs to test cache endpoints
-            timeout 10s ./example &
-            PID=$!
-            sleep 3
-
-            # Test health endpoint
-            if curl -f http://localhost:8080/health; then
-              echo "✅ cache-demo health check passed"
-            else
-              echo "❌ cache-demo health check failed"
-              kill $PID 2>/dev/null || true
-              exit 1
-            fi
-
-            kill $PID 2>/dev/null || true
-
-          elif [ "${{ matrix.example }}" = "scheduler-demo" ]; then
-            # Scheduler demo needs to test job scheduling
-            timeout 10s ./example &
-            PID=$!
-            sleep 3
-
-            # Test health endpoint
-            if curl -f http://localhost:8080/health; then
-              echo "✅ scheduler-demo health check passed"
-            else
-              echo "❌ scheduler-demo health check failed"
-              kill $PID 2>/dev/null || true
-              exit 1
-            fi
+          elif [ "${{ matrix.example }}" = "multi-engine-eventbus" ]; then
+            # Multi-engine eventbus example - use Redis for external service demo
+            echo "🔄 Testing multi-engine-eventbus with Redis service..."
 
-            kill $PID 2>/dev/null || true
+            # Make run-demo.sh executable
+            chmod +x run-demo.sh
 
-          elif [ "${{ matrix.example }}" = "eventbus-demo" ]; then
-            # EventBus demo needs to test pub/sub functionality
-            timeout 10s ./example &
-            PID=$!
-            sleep 3
-
-            # Test health endpoint
-            if curl -f http://localhost:8080/health; then
-              echo "✅ eventbus-demo health check passed"
-            else
-              echo "❌ eventbus-demo health check failed"
-              kill $PID 2>/dev/null || true
-              exit 1
-            fi
-
-            kill $PID 2>/dev/null || true
-
-          elif [ "${{ matrix.example }}" = "jsonschema-demo" ]; then
-            # JSON Schema demo needs to test validation endpoints
-            timeout 10s ./example &
-            PID=$!
-            sleep 3
-
-            # Test health endpoint
-            if curl -f http://localhost:8080/health; then
-              echo "✅ jsonschema-demo health check passed"
-            else
-              echo "❌ jsonschema-demo health check failed"
-              kill $PID 2>/dev/null || true
-              exit 1
-            fi
-
-            kill $PID 2>/dev/null || true
-
-          elif [ "${{ matrix.example }}" = "letsencrypt-demo" ]; then
-            # Let's Encrypt demo just needs to start (won't actually get certificates in CI)
-            timeout 5s ./example &
-            PID=$!
-            sleep 3
-
-            # Check if process is still running (no immediate crash)
-            if kill -0 $PID 2>/dev/null; then
-              echo "✅ letsencrypt-demo started successfully"
-              kill $PID 2>/dev/null || true
+            # Check if Docker is available for Redis
+            if command -v docker &> /dev/null; then
+              echo "Docker available, testing with Redis service"
+
+              # Try to start Redis and run the demo
+              if timeout 60s ./run-demo.sh run-redis; then
+                echo "✅ multi-engine-eventbus demo completed successfully with Redis"
+                # Clean up Redis container
+                docker-compose -f docker-compose.yml down -v 2>/dev/null || true
+              else
+                echo "⚠️ Redis demo failed, testing graceful degradation mode"
+                # Clean up any containers
+                docker-compose -f docker-compose.yml down -v 2>/dev/null || true
+
+                # Test graceful degradation (this should always work)
+                timeout 10s ./example &
+                PID=$!
+                sleep 5
+
+                if kill -0 $PID 2>/dev/null; then
+                  echo "✅ multi-engine-eventbus handles missing services gracefully"
+                  kill $PID 2>/dev/null || true
+                else
+                  echo "❌ multi-engine-eventbus failed to handle missing services"
+                  exit 1
+                fi
+              fi
             else
-              echo "❌ letsencrypt-demo failed to start or crashed immediately"
-              exit 1
+              echo "Docker not available, testing graceful degradation mode only"
+
+              # Test without external services (graceful degradation)
+              timeout 10s ./example &
+              PID=$!
+              sleep 5
+
+              if kill -0 $PID 2>/dev/null; then
+                echo "✅ multi-engine-eventbus handles missing services gracefully"
+                kill $PID 2>/dev/null || true
+              else
+                echo "❌ multi-engine-eventbus failed to handle missing services"
+                exit 1
+              fi
             fi
 
           elif [ "${{ matrix.example }}" = "reverse-proxy" ] || [ "${{ matrix.example }}" = "http-client" ] || [ "${{ matrix.example }}" = "advanced-logging" ] || [ "${{ matrix.example }}" = "verbose-debug" ] || [ "${{ matrix.example }}" = "instance-aware-db" ] || [ "${{ matrix.example }}" = "feature-flag-proxy" ]; then

.github/workflows/module-release.yml

@@ -14,11 +14,11 @@ on:
           - chimux
           - database
           - eventbus
-          - eventlogger
           - httpclient
           - httpserver
           - jsonschema
           - letsencrypt
+          - logmasker
           - reverseproxy
           - scheduler
       version: