Skip to content

fix(release): wrap before.hooks in sh -c (export builtin + YAML-quote URL colons) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intel352 merged 2 commits into from
May 3, 2026
Merged

fix(release): wrap before.hooks in sh -c (export builtin + YAML-quote URL colons) #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73f2f1f
fix(release): wrap before.hooks in sh -c for shell builtins/operators
intel352 May 3, 2026
87b02d5
fix(release): YAML-quote sh -c hooks (URL colons confuse YAML mapping)
intel352 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,19 @@ version: 2
project_name: workflow-plugin-digitalocean

before:
# goreleaser v2 exec's each hook string via shlex.Split rather than
# passing it to a shell, so shell builtins (export), shell operators
# (&&, ;), and command substitution ($(...)) only work when wrapped in
# `sh -c "<...>"`. The two sed lines below only worked accidentally:
# goreleaser passed everything past the first whitespace as args to
# `sed`, which silently absorbs `&&` and `rm` as positional args. The
# wfctl-validate line below contains `export` (a builtin) so was the
# first to actually fail; wrapping all three in `sh -c` makes the
# behaviour match the apparent intent.
hooks:
- "sed -i.bak 's/\"version\": \".*\"/\"version\": \"{{ .Version }}\"/' plugin.json && rm -f plugin.json.bak"
- "sed -i.bak 's|/releases/download/v[^/]*/|/releases/download/{{ .Tag }}/|g' plugin.json && rm -f plugin.json.bak"
- "export GOPRIVATE=github.com/GoCodeAlone/*; WFCTL_VERSION=$(go list -m github.com/GoCodeAlone/workflow | awk '{print $2}') && GOWORK=off go run github.com/GoCodeAlone/workflow/cmd/wfctl@${WFCTL_VERSION} plugin validate --file plugin.json --strict-contracts"
- "sh -c \"sed -i.bak 's/\\\"version\\\": \\\".*\\\"/\\\"version\\\": \\\"{{ .Version }}\\\"/' plugin.json && rm -f plugin.json.bak\""
- "sh -c \"sed -i.bak 's|/releases/download/v[^/]*/|/releases/download/{{ .Tag }}/|g' plugin.json && rm -f plugin.json.bak\""
- "sh -c \"export GOPRIVATE=github.com/GoCodeAlone/*; WFCTL_VERSION=$(go list -m github.com/GoCodeAlone/workflow | awk '{print $2}') && GOWORK=off go run github.com/GoCodeAlone/workflow/cmd/wfctl@${WFCTL_VERSION} plugin validate --file plugin.json --strict-contracts\""

# NOTE: removed top-level `after:` hook (introduced in #41). goreleaser
# v2 has no top-level `after:` hook — it failed v0.9.0's release at
Expand Down
Loading