Conversation
…parity with parent service) Agent-Logs-Url: https://github.com/GoCodeAlone/workflow-plugin-digitalocean/sessions/cd27a9ad-d099-4e6f-a03c-ad42223c4445 Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update buildJobSpec and buildWorkerSpec to accept structured map shape
fix: buildJobSpec/buildWorkerSpec — accept structured map image shape (parity with parent service)
May 5, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes App Platform build spec generation so buildJobSpec and buildWorkerSpec accept the image field in both supported canonical shapes—either a flat string image ref or a structured map[string]any—matching the behavior already used for the primary service image. This prevents structured image configs from being silently ignored for jobs/workers, which can lead to downstream DigitalOcean API rejections.
Changes:
- Updated
buildJobSpecandbuildWorkerSpecto useimageSpecFromConfig(string-or-map) instead of only parsing string image refs. - Added tests covering job/worker image handling for structured map shape, string shape (regression), and missing image (regression).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/drivers/app_platform_buildspec.go | Switch job/worker image parsing to imageSpecFromConfig to support both string and structured map image shapes. |
| internal/drivers/app_platform_buildspec_test.go | Add coverage for job/worker image parsing across map/string/empty cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildJobSpecandbuildWorkerSpeconly parsed theimagefield as a string viaParseImageRef, silently dropping the structured map form and causing DO API rejections ("job missing source spec"). The parent service already handled both shapes viaimageSpecFromConfig.Changes
app_platform_buildspec.go— replace inlinestrFromConfig + ParseImageRefinbuildJobSpecandbuildWorkerSpecwithimageSpecFromConfig, which accepts both string and map shapes:app_platform_buildspec_test.go— adds coverage for structured map, string, and empty image for both jobs and workers:TestBuildAppSpec_Jobs_ImageMapShape/TestBuildAppSpec_Workers_ImageMapShapeTestBuildAppSpec_Jobs_ImageStringShape/TestBuildAppSpec_Workers_ImageStringShape(regression)TestBuildAppSpec_Jobs_ImageEmpty/TestBuildAppSpec_Workers_ImageEmpty(regression)The structured map form now works on jobs and workers the same way it does on services: