Skip to content

chore: remove stale "ignores ctx" comment in provider_conformance_test.go#73

Merged
intel352 merged 3 commits intomainfrom
copilot/fix-do-provider-initialize-context
May 7, 2026
Merged

chore: remove stale "ignores ctx" comment in provider_conformance_test.go#73
intel352 merged 3 commits intomainfrom
copilot/fix-do-provider-initialize-context

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

DOProvider.Initialize was fixed in PR #68 to thread the caller-supplied ctx into oauth2.NewClient instead of context.Background(). A comment in provider_conformance_test.go still described the old broken behavior as if it were current, misleading future readers.

Changes

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 00:33
@intel352
Copy link
Copy Markdown
Contributor

intel352 commented May 7, 2026

iac-codemod refactor-apply report

Mode: dry-run
Sites: 1
Errors: 0

Skipped (// wfctl:skip-iac-codemod)

  • internal/provider.go:238 DOProvider.Apply skipped

Full report (90-day retention) attached as workflow artifact.

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 00:36
Copilot AI changed the title [WIP] Fix DOProvider.Initialize to use ctx parameter for godo client chore: remove stale "ignores ctx" comment in provider_conformance_test.go May 7, 2026
Copilot AI requested a review from intel352 May 7, 2026 00:37
@intel352 intel352 marked this pull request as ready for review May 7, 2026 00:51
@intel352
Copy link
Copy Markdown
Contributor

intel352 commented May 7, 2026

@copilot please review this PR now that it is ready for review.

Copilot AI review requested due to automatic review settings May 7, 2026 00:51
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 7, 2026

@copilot please review this PR now that it is ready for review.

The change is a single comment-only edit in provider_conformance_test.go. The old comment incorrectly described Initialize as still using context.Background() ("forward-prep rather than an immediate behavior change"). Since PR #68 already wires ctx into oauth2.NewClient (provider.go:82), the comment was factually wrong. The new version is accurate and concise.

The iac-codemod report is incidental — it flagged DOProvider.Apply (provider.go:238), which has a pre-existing intentional // wfctl:skip-iac-codemod marker that predates this PR. No action needed there.

No production code was changed; all TestDOProvider_Initialize_* tests pass. The PR is ready to merge.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the conformance test commentary to reflect the post-#62 behavior of DOProvider.Initialize (threading ctx into oauth2.NewClient) rather than the previously-stale “ignores ctx” note.

Changes:

  • Replaces the outdated “Initialize ignores ctx” multi-line note with a shorter comment referencing the fix in #62 / PR #68.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/provider_conformance_test.go Outdated
@intel352 intel352 merged commit 3d3b522 into main May 7, 2026
5 checks passed
@intel352 intel352 deleted the copilot/fix-do-provider-initialize-context branch May 7, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants