Conversation
iac-codemod refactor-apply reportMode: dry-run Skipped (// wfctl:skip-iac-codemod)
Full report (90-day retention) attached as workflow artifact. |
…already fixed in PR #68) Agent-Logs-Url: https://github.com/GoCodeAlone/workflow-plugin-digitalocean/sessions/962a09f7-575b-460c-85b7-d4de08c75f7b Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
|
@copilot please review this PR now that it is ready for review. |
The change is a single comment-only edit in The iac-codemod report is incidental — it flagged No production code was changed; all |
There was a problem hiding this comment.
Pull request overview
Updates the conformance test commentary to reflect the post-#62 behavior of DOProvider.Initialize (threading ctx into oauth2.NewClient) rather than the previously-stale “ignores ctx” note.
Changes:
- Replaces the outdated “Initialize ignores ctx” multi-line note with a shorter comment referencing the fix in #62 / PR #68.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DOProvider.Initializewas fixed in PR #68 to thread the caller-suppliedctxintooauth2.NewClientinstead ofcontext.Background(). A comment inprovider_conformance_test.gostill described the old broken behavior as if it were current, misleading future readers.Changes
internal/provider_conformance_test.go— replaces the now-false "forward-prep" note (which said Initialize ignores ctx) with a concise comment referencing the actual fix in DOProvider.Initialize ignores ctx parameter — godo client uses context.Background() #62 / PR fix/refactor(provider): Initialize ctx + Plan canonicalization (#62, #63) #68.