Skip to content

Confirm DOProvider.Plan canonicalization already resolved (issue #63)#74

Merged
intel352 merged 1 commit intomainfrom
copilot/refactor-provider-collapse-plan
May 7, 2026
Merged

Confirm DOProvider.Plan canonicalization already resolved (issue #63)#74
intel352 merged 1 commit intomainfrom
copilot/refactor-provider-collapse-plan

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

Issue #63 requested collapsing DOProvider.Plan to the canonical platform.ComputePlan 2-statement bridge. PR #68 already shipped this change (merged 2026-05-05) and explicitly closed #63.

Findings

  • internal/provider.go already contains the canonical form:
    func (p *DOProvider) Plan(ctx context.Context, desired []interfaces.ResourceSpec, current []interfaces.ResourceState) (*interfaces.IaCPlan, error) {
        plan, err := platform.ComputePlan(ctx, p, desired, current)
        return &plan, err
    }
  • All tests pass clean (-race -count=1 ./...).

No code changes required. Issue #63 and this PR can both be closed.

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 00:34
@intel352
Copy link
Copy Markdown
Contributor

intel352 commented May 7, 2026

iac-codemod refactor-apply report

Mode: dry-run
Sites: 1
Errors: 0

Skipped (// wfctl:skip-iac-codemod)

  • internal/provider.go:238 DOProvider.Apply skipped

Full report (90-day retention) attached as workflow artifact.

Copilot AI changed the title [WIP] Refactor provider to collapse Plan to platform.ComputePlan Confirm DOProvider.Plan canonicalization already resolved (issue #63) May 7, 2026
Copilot AI requested a review from intel352 May 7, 2026 00:39
@intel352 intel352 marked this pull request as ready for review May 7, 2026 00:51
@intel352
Copy link
Copy Markdown
Contributor

intel352 commented May 7, 2026

@copilot please review this PR now that it is ready for review.

Copilot AI review requested due to automatic review settings May 7, 2026 00:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 7, 2026

@copilot please review this PR now that it is ready for review.

Reviewed. The PR is in correct shape:

  • DOProvider.Plan (lines 187–190): canonical 2-statement platform.ComputePlan bridge — no codemod findings, as confirmed by the report above.
  • DOProvider.Apply (line 238): the // wfctl:skip-iac-codemod marker is intentional and correctly reflected in the codemod report as the one skipped site with 0 errors.

No issues found. Ready to merge / close issue #63.

@intel352 intel352 merged commit 5f298f1 into main May 7, 2026
7 checks passed
@intel352 intel352 deleted the copilot/refactor-provider-collapse-plan branch May 7, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOProvider.Plan still non-canonical — refactor to platform.ComputePlan

3 participants