fix: support dot-notation in resolveParamValue for integration step references#108
Merged
intel352 merged 2 commits intofix/stock-trading-stubfrom Feb 23, 2026
Merged
Conversation
5 tasks
…nces Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix stock trading stub with demo data
fix: support dot-notation in resolveParamValue for integration step references
Feb 23, 2026
intel352
added a commit
that referenced
this pull request
Feb 23, 2026
* fix: make stock trading stub explicit with demo data instead of silent zeros CheckPrice() previously returned 0,0,error when prices weren't seeded, giving users no data and no indication the example was a stub. Now it seeds a realistic AAPL-like opening price (182.50) on first call and applies a +0.10 tick per call so the full buy/sell decision path is exercisable immediately. Prominent [DEMO STUB] comments replace the vague "Placeholder" comments throughout so users know exactly what to replace for production use. Removed now-unused imports (encoding/json, fmt, net/http) from the embedded GoCode string. Closes #73 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: resolve gocritic sloppyReassign lint error in integration handler Replace err re-assignment with short variable declaration in handlers/integration.go to satisfy golangci-lint pre-push hook. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: support dot-notation in resolveParamValue for integration step references (#108) * Initial plan * fix: support dot-notation in resolveParamValue for step result references Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveParamValueclaimed to support${step1.value}references to prior step fields, butresultsstores step output keyed by step name (e.g.results["step1"] = map[string]any{...}), so${step1.value}would never resolve — only an exact key"step1.value"inresultswould match, which never exists.Changes
handlers/integration.go: After the fast exact-match path, split the variable name on.and traverse into the nestedmap[string]anystep result. Falls back to the original string if the step is missing, the result is not a map, or the nested key doesn't exist.handlers/integration_handler_test.go: Added tests covering dot-notation success, missing nested key, non-map step result, missing step, exact match, plain value passthrough, and non-reference strings.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.