Skip to content

fix: return 404 on deploy/stop for non-existent workflow IDs #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intel352 merged 2 commits into from
Feb 23, 2026
Merged

fix: return 404 on deploy/stop for non-existent workflow IDs #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f15ec
Initial plan
Copilot Feb 23, 2026
54e2867
fix: add 404 handling to deploy and stop workflow pipelines
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions admin/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,6 +1037,20 @@ workflows:
type: step.request_parse
config:
path_params: [id]
- name: check-exists
type: step.db_query
config:
database: admin-db
query: "SELECT id FROM workflows WHERE id = ?"
params: ["{{index .steps \"parse-request\" \"path_params\" \"id\"}}"]
mode: single
- name: check-found
type: step.conditional
config:
field: "steps.check-exists.found"
routes:
"false": not-found
default: set-now
- name: set-now
type: step.set
config:
Expand All @@ -1062,6 +1076,12 @@ workflows:
config:
status: 200
body_from: "steps.get-workflow.row"
- name: not-found
type: step.json_response
config:
status: 404
body:
error: "workflow not found"
# Stop: update workflow status to 'stopped'
- method: POST
path: "/api/v1/admin/workflows/{id}/stop"
Expand All @@ -1073,6 +1093,20 @@ workflows:
type: step.request_parse
config:
path_params: [id]
- name: check-exists
type: step.db_query
config:
database: admin-db
query: "SELECT id FROM workflows WHERE id = ?"
params: ["{{index .steps \"parse-request\" \"path_params\" \"id\"}}"]
mode: single
- name: check-found
type: step.conditional
config:
field: "steps.check-exists.found"
routes:
"false": not-found
default: set-now
- name: set-now
type: step.set
config:
Expand All @@ -1098,6 +1132,12 @@ workflows:
config:
status: 200
body_from: "steps.get-workflow.row"
- name: not-found
type: step.json_response
config:
status: 404
body:
error: "workflow not found"
# Load workflow from a server-local filesystem path
- method: POST
path: "/api/v1/admin/workflows/load-from-path"
Expand Down