docs: fix three inaccuracies in PLUGIN_DEVELOPMENT.md code examples#141
Merged
intel352 merged 2 commits intofeat/issue-84-engine-decomp-p4from Feb 23, 2026
Merged
docs: fix three inaccuracies in PLUGIN_DEVELOPMENT.md code examples#141intel352 merged 2 commits intofeat/issue-84-engine-decomp-p4from
intel352 merged 2 commits intofeat/issue-84-engine-decomp-p4from
Conversation
…gin error in PLUGIN_DEVELOPMENT.md Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add structural tests and validation for engine decomposition
docs: fix three inaccuracies in PLUGIN_DEVELOPMENT.md code examples
Feb 23, 2026
intel352
added a commit
that referenced
this pull request
Feb 23, 2026
…de & requires validation (#84) (#128) * feat: Engine Decomposition Phase 4 — structural tests, plugin dev guide, requires validation (#84) Add structural tests verifying: - Engine rejects unknown module types with clear errors - Workflow dependency validation fails for missing capabilities - Workflow dependency validation fails for missing plugins - Selective plugin loading: only loaded plugin types are available - All plugins have valid metadata (name, version, manifest) - Factory map populated correctly by plugins - Schema registry tracks all plugin module types Create docs/PLUGIN_DEVELOPMENT.md: - Comprehensive guide for creating internal EnginePlugin plugins - Covers ModuleFactories, StepFactories, TriggerFactories, WiringHooks - Documents capability contracts and workflow dependency validation - Includes example plugin structure and testing patterns Add requires section to license-validator example config. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: fix three inaccuracies in PLUGIN_DEVELOPMENT.md code examples (#141) * Initial plan * docs: fix PipelineStep signature, add slog import, and handle LoadPlugin error in PLUGIN_DEVELOPMENT.md Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three errors in the plugin development guide's code examples flagged in review.
PipelineStepinterface — correctedExecutereturn type fromerrorto(*StepResult, error)"log/slog"import required byslog.Default()usage in test examplesLoadPluginerror handling —TestModuleCreationwas silently discarding theLoadPluginreturn value; now fails fast witht.Fatalf✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.