fix: conflict detection for triggers/pipelines in MergeApplicationConfig, async context propagation, comment accuracy#145
Merged
intel352 merged 2 commits intofeat/issue-80-multi-workflowfrom Feb 23, 2026
Conversation
4 tasks
…, clarify comment Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add multi-workflow application config and cross-workflow invocation
fix: conflict detection for triggers/pipelines in MergeApplicationConfig, async context propagation, comment accuracy
Feb 23, 2026
intel352
added a commit
that referenced
this pull request
Feb 23, 2026
…tion (#133) * feat: add multi-workflow application config and cross-workflow invocation (#80) - Add ApplicationConfig format for multi-workflow applications referencing separate workflow YAML files with shared module registry - Add step.workflow_call pipeline step for cross-workflow invocation with sync (call-and-wait) and async (fire-and-forget) modes - Add input/output mapping with template expansion for data passing - Add pipelineRegistry to StdEngine for runtime pipeline lookup - Add BuildFromApplicationConfig() with module name conflict detection - Add auto-detection of application configs in cmd/server - Add step.workflow_call schema to module schemas - Add example multi-workflow app (chat platform with 3 workflows) - Add comprehensive tests for workflow call step and multi-config loading Closes #80 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: conflict detection for triggers/pipelines in MergeApplicationConfig, async context propagation, comment accuracy (#145) * Initial plan * fix: add conflict detection for triggers/pipelines, fix async context, clarify comment Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MergeApplicationConfigsilently overwrote duplicate trigger and pipeline names across merged workflow files, andConfigDirwas inconsistently set from the first workflow file rather than the application config. The asyncstep.workflow_callgoroutine usedcontext.Background(), decoupling it entirely from parent cancellation. A misleading comment in the server startup path misrepresented the actual build flow.Changes
Conflict detection (
config/config.go):MergeApplicationConfignow tracks seen trigger and pipeline names (viaseenTriggers/seenPipelines) and returns a descriptive error on collision — matching the existing module conflict behavior:ConfigDir consistency (
config/config.go):combined.ConfigDiris now pre-set fromappCfg.ConfigDirbefore the merge loop; the per-workflow fallback only applies when the application config dir is unset.Async context propagation (
module/pipeline_step_workflow_call.go): The fire-and-forget goroutine now derives its timeout context from the parentctxinstead ofcontext.Background(), allowing cancellation signals to propagate:Comment fix (
cmd/server/main.go): Removed the incorrect reference toBuildFromApplicationConfig; comment now accurately describes theMergeApplicationConfig → buildEngine → BuildFromConfigflow.Tests (
engine_multi_config_test.go): AddedTestBuildFromApplicationConfig_TriggerNameConflictandTestBuildFromApplicationConfig_PipelineNameConflict.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.