Skip to content

refactor: parameterize deploy/stop pipeline status to eliminate SQL literal duplication #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intel352 merged 2 commits into from
Feb 23, 2026
Merged

refactor: parameterize deploy/stop pipeline status to eliminate SQL literal duplication #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d4671
Initial plan
Copilot Feb 23, 2026
113da39
refactor: encapsulate deploy/stop status difference in set-target-sta…
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions admin/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,11 @@ workflows:
middlewares: [admin-cors, admin-auth-middleware]
pipeline:
steps:
- name: set-target-status
type: step.set
config:
values:
target_status: "active"
- name: parse-request
type: step.request_parse
config:
Expand Down Expand Up @@ -1060,8 +1065,9 @@ workflows:
type: step.db_exec
config:
database: admin-db
query: "UPDATE workflows SET status = 'active', updated_at = ? WHERE id = ?"
query: "UPDATE workflows SET status = ?, updated_at = ? WHERE id = ?"
params:
- "{{index .steps \"set-target-status\" \"target_status\"}}"
- "{{index .steps \"set-now\" \"now\"}}"
- "{{index .steps \"parse-request\" \"path_params\" \"id\"}}"
- name: get-updated
Expand Down Expand Up @@ -1089,6 +1095,11 @@ workflows:
middlewares: [admin-cors, admin-auth-middleware]
pipeline:
steps:
- name: set-target-status
type: step.set
config:
values:
target_status: "stopped"
- name: parse-request
type: step.request_parse
config:
Expand Down Expand Up @@ -1116,8 +1127,9 @@ workflows:
type: step.db_exec
config:
database: admin-db
query: "UPDATE workflows SET status = 'stopped', updated_at = ? WHERE id = ?"
query: "UPDATE workflows SET status = ?, updated_at = ? WHERE id = ?"
params:
- "{{index .steps \"set-target-status\" \"target_status\"}}"
- "{{index .steps \"set-now\" \"now\"}}"
- "{{index .steps \"parse-request\" \"path_params\" \"id\"}}"
- name: get-updated
Expand Down