Conversation
…t_from, url_reconstruction, include_form_params, and error_status support Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add step.webhook_verify for validating inbound webhook signatures
Add scheme-based webhook signature verification (HMAC-SHA1, secret_from, URL reconstruction)
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new scheme-based configuration mode to step.webhook_verify to support additional webhook signature formats (Twilio HMAC-SHA1, generic HMAC-SHA256, GitHub sha256=-prefixed hex), while keeping the legacy provider-based configuration intact.
Changes:
- Implement scheme-based verification, including
secret_fromdotted-path resolution and optional URL reconstruction / form-param signing input. - Extend unit tests to cover new schemes,
secret_from, URL reconstruction, and configurable error HTTP status. - Update
wfctlstep type registry to reflect the new configuration keys.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| module/pipeline_step_webhook_verify.go | Adds scheme-based config path (scheme, secret_from, signature_header, URL reconstruction, Twilio signing input, error status). |
| module/pipeline_step_webhook_verify_test.go | Adds scheme-based test coverage for HMAC-SHA1(base64), HMAC-SHA256(hex), GitHub prefix handling, secret_from, and error_status. |
| cmd/wfctl/type_registry.go | Updates CLI-known config keys for step.webhook_verify to include new scheme-based fields. |
Contributor
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.