Fix: Pipeline.RoutePattern not set for inline HTTP trigger pipelines#204
Merged
Fix: Pipeline.RoutePattern not set for inline HTTP trigger pipelines#204
Conversation
Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix RoutePattern not set for inline HTTP triggers in pipelines
Fix: Pipeline.RoutePattern not set for inline HTTP trigger pipelines
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing route-pattern propagation for pipelines executed via inline HTTP triggers, ensuring step.request_parse can extract path parameters by seeding _route_pattern into the pipeline execution metadata.
Changes:
- Populate
Pipeline.RoutePatternfrom inline HTTP triggerconfig.pathduringconfigurePipelines. - Seed
_route_patternfromPipeline.RoutePatterninsidePipeline.Executewhen not already present in metadata. - Add tests covering RoutePattern population and
_route_patternseeding/precedence behavior.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
engine.go |
Sets pipeline.RoutePattern from inline HTTP trigger path during pipeline configuration. |
module/pipeline_executor.go |
Seeds _route_pattern into execution metadata from Pipeline.RoutePattern when missing. |
engine_pipeline_test.go |
Adds tests verifying RoutePattern is set (or not set) for inline HTTP triggers. |
module/pipeline_executor_test.go |
Adds tests for _route_pattern seeding and precedence vs p.Metadata. |
module/pipeline_step_base64_decode.go |
Formatting/alignment changes only. |
module/pipeline_step_webhook_verify.go |
Formatting/alignment change only. |
Contributor
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engine.goconfigurePipelines, setpipeline.RoutePatternfrom inline HTTP triggerpathconfig after creating the pipelinemodule/pipeline_executor.goExecute(), seed_route_patternfromp.RoutePatternif not already in metadataRoutePatternis set for inline HTTP trigger pipelines inengine_pipeline_test.goRoutePatternNOT set when trigger path is empty inengine_pipeline_test.go_route_patternis seeded in pipeline context inExecute()(module/pipeline_executor_test.go)_route_patternfromp.Metadatatakes precedence overp.RoutePatterninExecute()_, ok := pc.Metadata["_route_pattern"]to properly assert key absence inTestPipeline_Execute_NoRoutePatternNoMetadata💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.