Skip to content

Fix: Pipeline.RoutePattern not set for inline HTTP trigger pipelines#204

Merged
intel352 merged 4 commits intomainfrom
copilot/fix-inline-http-trigger-routepattern
Feb 27, 2026
Merged

Fix: Pipeline.RoutePattern not set for inline HTTP trigger pipelines#204
intel352 merged 4 commits intomainfrom
copilot/fix-inline-http-trigger-routepattern

Conversation

Copy link
Contributor

Copilot AI commented Feb 27, 2026

  • Fix 1: In engine.go configurePipelines, set pipeline.RoutePattern from inline HTTP trigger path config after creating the pipeline
  • Fix 2: In module/pipeline_executor.go Execute(), seed _route_pattern from p.RoutePattern if not already in metadata
  • Add test: Verify RoutePattern is set for inline HTTP trigger pipelines in engine_pipeline_test.go
  • Add test: Verify RoutePattern NOT set when trigger path is empty in engine_pipeline_test.go
  • Add test: Verify _route_pattern is seeded in pipeline context in Execute() (module/pipeline_executor_test.go)
  • Add test: Verify _route_pattern from p.Metadata takes precedence over p.RoutePattern in Execute()
  • Fix test: Use two-value map access _, ok := pc.Metadata["_route_pattern"] to properly assert key absence in TestPipeline_Execute_NoRoutePatternNoMetadata
  • Run linter and tests - all pass with no regressions

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix RoutePattern not set for inline HTTP triggers in pipelines Fix: Pipeline.RoutePattern not set for inline HTTP trigger pipelines Feb 27, 2026
@intel352 intel352 marked this pull request as ready for review February 27, 2026 14:52
Copilot AI review requested due to automatic review settings February 27, 2026 14:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes missing route-pattern propagation for pipelines executed via inline HTTP triggers, ensuring step.request_parse can extract path parameters by seeding _route_pattern into the pipeline execution metadata.

Changes:

  • Populate Pipeline.RoutePattern from inline HTTP trigger config.path during configurePipelines.
  • Seed _route_pattern from Pipeline.RoutePattern inside Pipeline.Execute when not already present in metadata.
  • Add tests covering RoutePattern population and _route_pattern seeding/precedence behavior.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
engine.go Sets pipeline.RoutePattern from inline HTTP trigger path during pipeline configuration.
module/pipeline_executor.go Seeds _route_pattern into execution metadata from Pipeline.RoutePattern when missing.
engine_pipeline_test.go Adds tests verifying RoutePattern is set (or not set) for inline HTTP triggers.
module/pipeline_executor_test.go Adds tests for _route_pattern seeding and precedence vs p.Metadata.
module/pipeline_step_base64_decode.go Formatting/alignment changes only.
module/pipeline_step_webhook_verify.go Formatting/alignment change only.

@intel352
Copy link
Contributor

@copilot apply changes based on the comments in this thread

Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
@intel352 intel352 merged commit fc0ff5d into main Feb 27, 2026
14 checks passed
@intel352 intel352 deleted the copilot/fix-inline-http-trigger-routepattern branch February 27, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants