feat: GetAsset RPC, sample plugin manifest, DeepMergeConfigs#212
Merged
feat: GetAsset RPC, sample plugin manifest, DeepMergeConfigs#212
Conversation
Extend the gRPC plugin protocol to support embedded static asset serving and sample app metadata, enabling one-click trial deployments in cloud. - Proto: add GetAsset RPC + config_mutable/sample_category manifest fields - SDK: add AssetProvider interface, extend PluginManifest - gRPC server: implement GetAsset with AssetProvider type assertion - Adapter: add GetAsset, IsSamplePlugin, IsConfigMutable, SampleCategory, ConfigFragmentBytes accessors - Config: add DeepMergeConfigs with override-wins semantics for tenant config customization (distinct from existing MergeConfigs primary-wins) - Tests for all new functionality Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
- Add nolint:nilerr for gRPC response-level error pattern in GetAsset - Remove unused minimalProvider embedding in sampleProvider test type Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetAssetRPC to gRPC plugin protocol for serving embedded static assets (UI files) without filesystem extractionconfig_mutableandsample_categoryfields to pluginManifestproto messageAssetProviderSDK interface and extendPluginManifeststructGetAssethandler in gRPC server withAssetProvidertype assertionExternalPluginAdapter:GetAsset,IsSamplePlugin,IsConfigMutable,SampleCategory,ConfigFragmentBytesDeepMergeConfigswith override-wins semantics (distinct from existingMergeConfigsprimary-wins) for tenant config customizationTest plan
go build ./...passesgo test ./config/...— DeepMerge tests (nil handling, module matching, nested recursion, workflow/pipeline override)go test ./plugin/...— GetAsset with/without AssetProvider, MIME detection, new manifest fields, adapter accessorsgo test ./...— full suite passes🤖 Generated with Claude Code