feat: pgx driver + WorkflowDatabase Start/Stop lifecycle#215
Merged
Conversation
Register the pgx/v5 stdlib driver alongside SQLite so database.workflow module can connect to PostgreSQL out of the box. Add Start(ctx)/Stop(ctx) methods to WorkflowDatabase so the modular framework auto-opens the DB connection at startup and closes it at shutdown. This removes the need for a separate persistence.store module when using database.workflow for direct SQL pipeline steps (db_query, db_exec). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgx/v5stdlib driver alongside SQLite inmodule/database_drivers.gosodatabase.workflowcan connect to PostgreSQL without a separate driver importStart(ctx)/Stop(ctx)methods toWorkflowDatabaseso the modular framework auto-opens the DB at startup and closes at shutdownpersistence.storemodule when usingdatabase.workflowfor SQL pipeline steps (db_query,db_exec)Context
BuyMyWishlist and other PostgreSQL-first deployments use
database.workflowwithdriver: pgxdirectly. WithoutStart()/Stop(), the DB connection wasn't opened until the first step tried to use it, and there was no clean shutdown. Without the pgx driver import, users had to add it manually.Test plan
go build ./...passesgo test ./module/...passes🤖 Generated with Claude Code