fix: remove unlambda wrapper in pipeline template toFloat function#239
Merged
fix: remove unlambda wrapper in pipeline template toFloat function#239
Conversation
Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix linter failures in the codebase
fix: remove unlambda wrapper in pipeline template toFloat function
Mar 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant wrapper lambda in the pipeline template function map to satisfy golangci-lint (gocritic unlambda) while keeping template behavior unchanged.
Changes:
- Replace
"toFloat": func(v any) float64 { return toFloat64(v) }with"toFloat": toFloat64in the templateFuncMap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lintreported agocriticunlambdaviolation — a redundant wrapper lambda that simply delegates to an existing function.Change
module/pipeline_template.go: Replace the unnecessary wrapperfunc(v any) float64 { return toFloat64(v) }with a direct reference totoFloat64🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.