Added contents of triggering message to signal_queue_size_change#46
Open
tsaubergine wants to merge 1 commit into2.1from
Open
Added contents of triggering message to signal_queue_size_change#46tsaubergine wants to merge 1 commit into2.1from
tsaubergine wants to merge 1 commit into2.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the DCCL message that triggers the queue size change, if one exists. For a shrinking queue this is the message that was just popped, for a growing queue this is the message that was just pushed.
Rather than modify the signature of
signal_queue_size_changed, I added this as an additional optional field to the QueueSize message.@glgrobe Could you please review and see if this fits your needs.
This block of the Queue3 unit test shows how to extract the encoded message:
https://github.com/GobySoft/goby/compare/2.1-queue-size-add-encoded-message?expand=1#diff-0846765b1bb6e76a7fed8bdf73a334e9R203