Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a client crash that occurred when pressing Alt+Enter to toggle fullscreen mode. The crash was caused by DXGI's built-in Alt+Enter handler calling SetFullscreenState internally without the application's knowledge, which put the swap chain in an inconsistent state and caused the next Present() call to fail.
Changes:
- Disabled DXGI's built-in Alt+Enter handling using
MakeWindowAssociationwithDXGI_MWA_NO_ALT_ENTER - Implemented custom Alt+Enter handling in the message handler to toggle between fullscreen and windowed modes
- Added renderer null check in the message handler for safety
- Fixed missing break statement after WM_ACTIVATEAPP case
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| game_patch/graphics/d3d11/gr_d3d11_hooks.cpp | Added custom Alt+Enter handler in WM_SYSKEYDOWN, added renderer null check, and fixed missing break statement |
| game_patch/graphics/d3d11/gr_d3d11.cpp | Disabled DXGI's built-in Alt+Enter handling via MakeWindowAssociation |
| docs/CHANGELOG.md | Added changelog entry documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The reason |
Added comments regarding DXGI's flip presentation model and fullscreen toggle handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggles between fullscreen and windowed/borderless now.