Allow css classes to come from self.attrs without being overwritten.#39
Open
amjoconn wants to merge 7 commits intoGoodCloud:masterfrom
Open
Allow css classes to come from self.attrs without being overwritten.#39amjoconn wants to merge 7 commits intoGoodCloud:masterfrom
amjoconn wants to merge 7 commits intoGoodCloud:masterfrom
Conversation
Update forms.py to support Python 3
Update zebra_tags.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using a bootstrap form mixin which includes code similar to this
It depends on the value of field.widget.attrs['class'] being propagated to the rendered widget.
One could argue that Django should be doing the combining for us, but it doesn't, for now this works, and I don't believe will cause any other issues.