Make goodeye register interactive when run without --email#37
Merged
Conversation
A bare 'goodeye register' previously errored on a missing --email option, leaving new users with no interactive path (only 'goodeye login' had one). Register now shares the same browser/device-code flow as login, which creates the account for new users, while 'register --email' stays for automation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A bare
goodeye registerpreviously errored on a missing--emailoption, so a new user reaching for "register" hit a dead-end. The only interactive path wasgoodeye login.registerwith no arguments now runs the same browser/device-code sign-in flow aslogin(the hosted sign-in page creates the account for new users and signs in returning users).register --emailis unchanged for agents and automation, and it gained--referral-codefor parity withlogin.The interactive flow is factored into a shared
run_interactive_loginhelper sologinandregisterstay in lockstep.Tests
Added interactive-
registercoverage (with/without referral, bare-register-runs-device-code,register --helpparity). Full suite green: 748 passed, ruff + ruff-format clean, pyright 0 errors.Also bumps the version to 0.18.2.
🤖 Generated with Claude Code