This repository was archived by the owner on Feb 13, 2026. It is now read-only.
Ui update#3
Open
Bill-P wants to merge 3 commits into
Open
Conversation
orviwan
suggested changes
Jan 8, 2018
orviwan
left a comment
orviwan
left a comment
Contributor
There was a problem hiding this comment.
Thanks Bill, some minor nits.
| @@ -1,7 +1,15 @@ | |||
| { | |||
| "fitbit": { | |||
| "appUUID": "0cb04f31-513b-4afe-9bea-3c6eb955f583", | |||
Contributor
There was a problem hiding this comment.
Please don't include appUUID in the example.
| @@ -0,0 +1 @@ | |||
| {"appManifestVersion":1,"main":"app/index.js","svgMain":"resources/index.gui","svgWidgets":"resources/widgets.gui","appType":"app","i18n":{"en":{"name":"Altimeter"}},"buildId":"0x0ab90f121979b2ad","uuid":"0cb04f31-513b-4afe-9bea-3c6eb955f583","name":"Altimeter","bundleDate":"2018-01-01T17:01:16.275Z","requestedPermissions":[],"wipeColor":"#03a9f4"} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
We don't need the manifest file.
| bar.onreading = function() { | ||
| altitudeLabel.innerText = altitudeFromPressure(bar.pressure / 100) + " ft"; | ||
| pressureLabel.innerText = Math.round(bar.pressure / 100) + " hPa"; | ||
| altitudeLabel.text = Math.round(altitudeFromPressure(bar.pressure / 100)*100)/100 + " ft"; |
Contributor
There was a problem hiding this comment.
This probably needs simplifying a bit.
| <svg> | ||
| <text id="altitude" x="50%" y="180" class="large-value">altitude</text> | ||
| <text id="pressure" x="50%" y="230" class="small-value">pressure</text> | ||
| <text id="altitude-Label" x="50%" y="50" class="label">Pressure altitude</text> |
Contributor
There was a problem hiding this comment.
Lowercase "label" for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Labels to UI and Truncates the Pressure Altitude to 2 decimal points