Draft
Conversation
WillowGriffiths
force-pushed
the
add-cargo-deny
branch
from
c67c4a6 to
9a4f7a0
Compare
The project currently fails due to the ranges crate's LGPL license (see #127). In addition, some unmaintained dependencies were added to the advisories ignore list. Perhaps this should be investigated.
WillowGriffiths
force-pushed
the
add-cargo-deny
branch
from
9a4f7a0 to
8722ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would prevent issues like #127 from cropping up in the future by using
cargo-denyto lint dependencies for license conflicts and security advisories.Considerations before merging:
Currently a number of unmaintained packages down the dependency graph are added to
cargo-deny's 'ignore' list as they would otherwise be counted as blocking security advisories.Gating the CI pipeline on security advisories may be problematic; it could begin to fail suddenly if a new security advisory is added to the registry.
ranges dependency uses LGPL-3.0-or-later license #127 must be fixed before the new tests can pass.cargo-denyalso flags up a few duplicate dependencies. Should this be considered important?Tests pass
Appropriate changes to README are included in PR
Depends on #131.