This repository was archived by the owner on Dec 25, 2021. It is now read-only.
Headless test using puppeteer#13
Open
samarpanda wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Open
Conversation
philipwalton
suggested changes
Jan 30, 2019
Contributor
philipwalton
left a comment
philipwalton
left a comment
There was a problem hiding this comment.
Thanks, I think this looks good so far. I left a few comments inline.
samarpanda
changed the title
Author
|
@philipwalton Could you please review my PR? |
samarpanda
changed the title
pupeteer test added updated nodejs version travis build status tag added
Author
|
@philipwalton Final review pending on this PR. Please pick this when you are available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headless test using puppeteer
Created a basic node server which serves an index.html file. First-Input-delay.js file added to its head. Puppeteer loads this file & triggers
mousedownevent.Todos
click&touchstartkeydown&mousedown@philipwalton Would like to get a first round of feedback on this. So, i can get this PR ready by next week.
Need some help to configure 3 point of todos.