This repository was archived by the owner on Jul 8, 2020. It is now read-only.
fix: run endpoint with output json by default#46
Open
jepser wants to merge 1 commit into
Open
Conversation
Contributor
|
This should already be taken care of here: https://github.com/ebidel/lighthouse-ci/blob/master/frontend/server.js#L172 |
Author
|
It's but if you send the payload without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://lighthouse-ci.appspot.com/run_on_chrome it was failing if output is not provided. So now it works by set
outputproperty tojsonby default.This didn't work:
With this PR it does.