Reset in-flight payment request & delay timer on new payment request - #15
Merged
stephenmcgruer merged 1 commit intoAug 13, 2026
Merged
Conversation
…request event Previously, if consecutive payment requests invoke and close immediately before loading view finishes loading, the timer from previous payment request will try to openWindow after its timer times out. This change fixes this by: - Storing delay timer ID in global currentPayment.delayTimtoutId - Cancling any pending timer via clearTimeout() and resetting global payment state when a new paymentrequest event arrives. - Resetting delayTimeoutId to null upon normal timer completion.
stephenmcgruer
left a comment
Collaborator
There was a problem hiding this comment.
Is it feasible instead to update the service worker to handle multiple in-flight payment requests? Or is it too complicated to coordinate messages/etc in that scenario?
Collaborator
Discussed offline, we will do this as a follow-up |
stephenmcgruer
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if consecutive payment requests invoke and close immediately before loading view finishes loading, the timer from previous payment request will try to openWindow after its timer times out.
This change fixes this by: