Conversation
enocom
force-pushed
the
uv
branch
6 times, most recently
from
c7ba839 to
19eef18
Compare
| self._keys: Optional[asyncio.Task] = None | ||
| try: | ||
| self._keys: Optional[asyncio.Task] = asyncio.create_task(generate_keys()) | ||
| asyncio.get_running_loop() |
Collaborator
There was a problem hiding this comment.
Why do you need to call asyncio.get_running_loop() here?
Member
Author
There was a problem hiding this comment.
Added a comment just above to explain why. Short answer: prior to this change when an event loop was not running, we would be starting the generate_keys coroutine, but never await it and therefore leak it. The addition of get_running_loop ensures we never leak a coroutine.
| @@ -96,6 +97,7 @@ def __init__( | |||
| # loop. See https://github.com/GoogleCloudPlatform/alloydb-python-connector/issues/435 | |||
| # for more details. | |||
| self._is_sync = False | |||
Collaborator
There was a problem hiding this comment.
Can we remove this line since we don't use self._is_sync anymore?
rhatgadkar-goog
requested changes
Apr 8, 2026
This commit replaces the existing build-tooling with uv. In addition, all CI operations are captured in scripts to make it easier to run linting, formatting, unit tests, and system tests locally without having to remember the exact set of commands. Fixes #443.
rhatgadkar-goog
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the existing build-tooling with uv. In addition,
all CI operations are captured in scripts to make it easier to run
linting, formatting, unit tests, and system tests locally without having
to remember the exact set of commands.
Fixes #443.