This repository was archived by the owner on Jan 11, 2023. It is now read-only.
knative: Add knative package#107
Open
gvso wants to merge 9 commits intoGoogleCloudPlatform:anthos-supportfrom
gvso:knative-package
Open
knative: Add knative package#107gvso wants to merge 9 commits intoGoogleCloudPlatform:anthos-supportfrom gvso:knative-package
gvso wants to merge 9 commits intoGoogleCloudPlatform:anthos-supportfrom
gvso:knative-package
Conversation
This was referenced Aug 21, 2020
added 5 commits
August 25, 2020 12:50
This adds a knative package and moves the run package inside it. The package declares an interface representing a Knative Provider, which the cloudrun package implements. Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
added 3 commits
August 25, 2020 12:58
Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
ahmetb
reviewed
Aug 26, 2020
ahmetb
reviewed
Aug 26, 2020
Comment on lines
+28
to
+32
| // regions are the available regions. | ||
| // | ||
| // TODO: caching regions might be unnecessary if we are querying them once during | ||
| // the lifespan of the process. | ||
| var regions = []string{} |
ahmetb
reviewed
Aug 26, 2020
| } | ||
|
|
||
| // ServicesWithLabelSelector gets services filtered by a label selector. | ||
| func (p *Provider) ServicesWithLabelSelector(namespace string, labelSelector string) ([]*run.Service, error) { |
Contributor
There was a problem hiding this comment.
simpler name like ListServices
Signed-off-by: Getulio Valentin Sánchez <gvso@google.com>
Contributor
|
cc: @grayside if you have time, would be great to take a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a knative package and moves the run package inside it. The package declares an interface representing a Knative Provider, which the cloudrun package implements.