fix(agy_cli): drop unsupported -- delimiter from plugin install#455
Merged
Conversation
agy's plugin subcommand parser does not honor `--`, so it took the delimiter as the install target and failed with `install target must be a directory: --`. Remove it. Also fix `_log_installed_plugins` to read plugin names from the manifest `imports` array, and correct docs/comments that advertised the unreliable `plugin@marketplace` target form.
Collaborator
Author
|
/gcbrun |
…y CLI testing docs
Collaborator
Author
|
/gcbrun |
prernakakkar-google
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agy plugin installfailed at setup because the harness passed a--end-of-options delimiter that agy's subcommand parser does not honor — it
took
--as the install target (install target must be a directory: --).Removed it.
_log_installed_pluginsto read plugin names from the manifestimportsarray (was logging['imports']).plugin@marketplacetargetform, which is unreliable (agy resolves marketplace names server-side; e.g.
gemini-cli-extensionsis not recognized). Use a git URL or local directory.Test plan
pytest evalbench/test/agy_cli_test.py(44 passed)./evalbench/run.shinstallscloud-sql-postgresqlsuccessfully