Skip to content

fix(dea): accumulate all recursion agent text parts#456

Merged
graceqi-g merged 1 commit into
GoogleCloudPlatform:mainfrom
minzznguyen:fix_gcp_dea_recursion_text
Jun 24, 2026
Merged

fix(dea): accumulate all recursion agent text parts#456
graceqi-g merged 1 commit into
GoogleCloudPlatform:mainfrom
minzznguyen:fix_gcp_dea_recursion_text

Conversation

@minzznguyen

Copy link
Copy Markdown
Contributor

Description

  • old implementation was only able to extract the top level of the agent's response
  • old implementation only output unnecessary logs when finding iterable objects
  • this change provide fix by appending message text instead of returning prematurely, and have helper functions for finding iterable objects

@minzznguyen minzznguyen requested a review from IsmailMehdi as a code owner June 23, 2026 18:59

@graceqi-g graceqi-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you attach log of the parsed agent text before and after your change?

also, do the UTs for the generator need to be updated? can you add some around the text parsing if possible?

Comment thread evalbench/generators/models/gcp_data_engineering_agent.py Outdated
@minzznguyen minzznguyen force-pushed the fix_gcp_dea_recursion_text branch from 5ab6d49 to ad0835f Compare June 23, 2026 20:38
@IsmailMehdi

Copy link
Copy Markdown
Collaborator

/gcbrun

IsmailMehdi
IsmailMehdi previously approved these changes Jun 23, 2026
@minzznguyen

minzznguyen commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

can you attach log of the parsed agent text before and after your change?

Here is the formatted before and after log - key point to look is that the before section only has messages saying what the agent will do for each turn, while the after section contains messages saying what the agent will do and also message reviewing the code that the agent just generated:

https://docs.google.com/document/d/1WfbFvipzvzBXdex4j8OZHzZwl7eqihq1md4rLKIVL1M/edit?tab=t.jh4qb22b4ubk

@graceqi-g

Copy link
Copy Markdown
Collaborator

can you attach log of the parsed agent text before and after your change?

Here is the formatted before and after log - key point to look is that the before section only has messages saying what the agent will do for each turn, while the after section contains messages saying what the agent will do and also message reviewing the code that the agent just generated:

https://docs.google.com/document/d/1WfbFvipzvzBXdex4j8OZHzZwl7eqihq1md4rLKIVL1M/edit?tab=t.jh4qb22b4ubk

looks good! are you able to add a UT to the generator to ensure the agent text is parsed properly?

@minzznguyen minzznguyen force-pushed the fix_gcp_dea_recursion_text branch from 13125eb to 8e27e75 Compare June 23, 2026 23:56
@graceqi-g

Copy link
Copy Markdown
Collaborator

/gcbrun

@graceqi-g graceqi-g merged commit cf3f758 into GoogleCloudPlatform:main Jun 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants