Skip to content

Feature/testing audio22 module #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pradhyumnap-hub wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

Feature/testing audio22 module #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1d6b059
files copyed from pr 90
pradhyumnap-hub Mar 23, 2026
eee5214
fdescribe reomved
pradhyumnap-hub Mar 23, 2026
26def4c
develop branch version of file
pradhyumnap-hub Mar 24, 2026
5bdb801
fixes Snackbar to NotificationService
pradhyumnap-hub Mar 24, 2026
98523f2
`this.isLoading` is not set to `true` at the beginning of this method…
pradhyumnap-hub Mar 24, 2026
1072b15
space removed
pradhyumnap-hub Mar 24, 2026
b0c67be
The indentation inside this block is incorrect and misaligned with th…
pradhyumnap-hub Mar 24, 2026
ee14397
Missing space after the comma.
pradhyumnap-hub Mar 24, 2026
cca9dbd
There is an extra space in the indentation here.
pradhyumnap-hub Mar 24, 2026
014cdf4
There is an extra space in the indentation here.
pradhyumnap-hub Mar 24, 2026
3a1e2f9
The closing parenthesis has incorrect indentation. It should align wi…
pradhyumnap-hub Mar 24, 2026
72303db
Removing `void` here can lead to unhandled promise rejections or lint…
pradhyumnap-hub Mar 24, 2026
de58056
Consider keeping the blank line between methods for better readability.
pradhyumnap-hub Mar 24, 2026
5340670
new line added
pradhyumnap-hub Mar 24, 2026
abc8fe4
This test asserts a duration of `20000`, but the component code uses …
pradhyumnap-hub Mar 24, 2026
a1ca00f
Consider removing `MatSnackBar` from the imports and the constructor.…
pradhyumnap-hub Mar 24, 2026
039ea68
This test block is an exact duplicate of the `togglePlay should call …
pradhyumnap-hub Mar 24, 2026
3e458e2
Consider adding a newline at the end of the file to adhere to POSIX s…
pradhyumnap-hub Mar 24, 2026
3d700f6
This test case is an exact duplicate of the test case immediately ab…
pradhyumnap-hub Mar 25, 2026
b1d509e
Setting `this.isLoading = false;` here is unnecessary since `isLoadin…
pradhyumnap-hub Mar 25, 2026
5dc788d
commented code removed
pradhyumnap-hub Mar 25, 2026
90264b8
Consider extracting the error message from the backend response for c…
pradhyumnap-hub Mar 25, 2026
e881753
indent fixed
pradhyumnap-hub Mar 25, 2026
976d5fb
The error message extraction logic could be more robust. If `error?.e…
pradhyumnap-hub Mar 25, 2026
fe9f025
The error message extraction logic here is missing the `typeof` check…
pradhyumnap-hub Mar 25, 2026
ccbff1a
The duration expected here (`20000`) does not match the actual durati…
pradhyumnap-hub Mar 25, 2026
679a4e5
Using `as any` bypasses TypeScript's type checking. Consider definin…
pradhyumnap-hub Mar 27, 2026
bbf2ac2
Missing call to component.openAddVoiceDialog() in the test case. The …
pradhyumnap-hub Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading