Skip to content

2 file copyed from PR81 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pradhyumnap-hub wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

2 file copyed from PR81 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
70d7e3e
2 file copyed from PR81
pradhyumnap-hub Mar 10, 2026
9480c2b
missing media item properties added
pradhyumnap-hub Mar 11, 2026
2da4a06
audio test cases fixed
pradhyumnap-hub Mar 11, 2026
804fb04
added newline at end of file
pradhyumnap-hub Mar 12, 2026
d93c630
unused imports removed
pradhyumnap-hub Mar 12, 2026
92ae4f2
unused imports removed
pradhyumnap-hub Mar 12, 2026
4355cb6
Unnecessary tick. The `NotificationService.show` method is fully mock…
pradhyumnap-hub Mar 12, 2026
6b8574e
comment removed
pradhyumnap-hub Mar 12, 2026
b219b38
unused imports removed
pradhyumnap-hub Mar 12, 2026
f5e19dd
commened code deleted
pradhyumnap-hub Mar 12, 2026
22486a4
Update frontend/src/app/audio/audio.component.spec.ts
pradhyumnap-hub Mar 12, 2026
38c42f9
multiple lines removed
pradhyumnap-hub Mar 12, 2026
3cd71c7
Consider using the `MediaItem` type here instead of `any` to maintain…
pradhyumnap-hub Mar 12, 2026
f818b4e
Consider using the `MediaItem` type instead of `any` for better type …
pradhyumnap-hub Mar 12, 2026
dffbb57
Consider adding a trailing comma for consistency with other method ca…
pradhyumnap-hub Mar 12, 2026
212b508
Consider removing the extra blank line for cleaner formatting.
pradhyumnap-hub Mar 12, 2026
eae8fa4
Consider adding a blank line before this test block to maintain consi…
pradhyumnap-hub Mar 12, 2026
7d6d956
If the duration is updated in the component, make sure to update it i…
pradhyumnap-hub Mar 13, 2026
96895fe
Consider reducing the error notification duration here as well, or de…
pradhyumnap-hub Mar 13, 2026
cb10646
20 seconds (`20000` ms) is quite long for a UI notification, especia…
pradhyumnap-hub Mar 13, 2026
09f080e
If the duration is updated in the component, make sure to update it …
pradhyumnap-hub Mar 13, 2026
c87775d
`ActivatedRoute` is provided here, but `AudioComponent` doesn't use i…
pradhyumnap-hub Mar 13, 2026
a5fe55f
Consider adding an additional test case to verify that backend valida…
pradhyumnap-hub Mar 17, 2026
be3ec9d
The test is asserting a notification duration of 20000 ms, but the ac…
pradhyumnap-hub Mar 17, 2026
b3ac083
Missing a space or newline before the comment for better readability.
pradhyumnap-hub Mar 18, 2026
88e9b29
The `tick(5000)` call here is unnecessary since `notificationService…
pradhyumnap-hub Mar 18, 2026
0a7f4a5
multiple fixes added for resolve test cases
pradhyumnap-hub Mar 20, 2026
070e0d3
The success notification is missing a duration and may remain on the …
pradhyumnap-hub Mar 20, 2026
f5b7f84
Update the test to reflect the added duration in the component's `not…
pradhyumnap-hub Mar 20, 2026
f2c4bd8
It is best to avoid mutating component state before input validation.…
pradhyumnap-hub Mar 23, 2026
9894958
Consider adding a test case to cover the FastAPI-specific error respo…
pradhyumnap-hub Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading