KSP based signing fixes#66
Open
kirillkovalenko wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
Open
KSP based signing fixes#66kirillkovalenko wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
kirillkovalenko wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
Conversation
On Windows 11 NCRYPT_PERSIST_ONLY_FLAG is being passed to GetKeyProperty And 0 is a valid legacy flag open opening KSP key according to the documentation.
Also answer "CLR IsEphemeral" property to reduce logging noise
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest CNG Provider does not seem to really work on Windows 11.
This PR contains two code and one build fixes. Once applied signtool.exe and .NET CmsSigner (via .NET X509Certificate2) starts to work.
I suspect that the build fix may actually be dropped in your environment.