fix(okf): exclude reserved log.md from concept enumeration#149
Open
larioscow wants to merge 1 commit into
Open
fix(okf): exclude reserved log.md from concept enumeration#149larioscow wants to merge 1 commit into
larioscow wants to merge 1 commit into
Conversation
SPEC §3.1 reserves both index.md and log.md, but the reference implementation skipped only index.md. A log.md was therefore surfaced as an Unknown-type node in the viewer graph and listed as a concept in generated index.md files. Centralize the reserved-filename set and use it in both the viewer and the index generator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPEC §3.1 reserves both
index.mdandlog.md, but the reference implementation only skippedindex.md. Alog.mdshowed up as anUnknownnode in the viewer (_walk_concepts) and as a concept entry in generatedindex.mdfiles (regenerate_indexes).Centralizes the reserved names in one
RESERVED_FILENAMESset inbundle/paths.pyand uses it at both sites, instead of the per-module"index.md"literals that drifted and caused the miss.Adds
test_log_md_is_not_a_conceptandtest_regenerate_excludes_reserved_log_md