Skip to content

Ansible: Backend Bucket Fixes#146

Merged
rambleraptor merged 1 commit into
GoogleCloudPlatform:masterfrom
rambleraptor:ansible-bb-fixes
May 4, 2018
Merged

Ansible: Backend Bucket Fixes#146
rambleraptor merged 1 commit into
GoogleCloudPlatform:masterfrom
rambleraptor:ansible-bb-fixes

Conversation

@rambleraptor

Copy link
Copy Markdown
Contributor

Backend Bucket Fixes for Ansible

  • Removed required: true for state
  • Spelling fix

[all]

Ansible: Backend Bucket fixes

[terraform]

[puppet]

[puppet-dns]

[puppet-sql]

[puppet-compute]

Spelling fix for Backend Bucket

[chef]

Comment thread templates/ansible/resource.erb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a condition for this else statement?

@rambleraptor

Copy link
Copy Markdown
Contributor Author

This PR includes all of the changes in #145 (I'm trying to nest PRs). Only the most recent commit on this is relevant for this PR

@modular-magician

Copy link
Copy Markdown
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#1418
depends: GoogleCloudPlatform/puppet-google-compute#26

Change-Id: I8911679ded1040416f79344a4747fd3f61af37ac
@rambleraptor

Copy link
Copy Markdown
Contributor Author

PTAL

@modular-magician

Copy link
Copy Markdown
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 3901fc4) have been included in your existing downstream PRs.

@rambleraptor rambleraptor merged commit ccb1672 into GoogleCloudPlatform:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants