artifactregistry: Remove Immutable from upstream_credentials

[NA2047]

Fixes for hashicorp/terraform-provider-google#20520 and hashicorp/terraform-provider-google#20520

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

artifactregistry: Allows `upstream_credentials` to be updated in place

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[trodge]

Do we have an update test for these fields?

[NA2047]

Do we have an update test for these fields?

Hey @trodge I'll write one :)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2dcd3ab:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	2 files changed, 129 insertions(+), 4 deletions(-)
google-beta provider	View Diff	2 files changed, 129 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	2 files changed, 3 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
54	43	10	1

Affected Service Packages

• artifactregistry

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccArtifactRegistryRepository_remoteWithAuthUpdate

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccArtifactRegistryRepository_remoteWithAuthUpdate

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047, @Subserial, @trodge VCR tests complete for 2dcd3ab!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5e40bc5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	2 files changed, 129 insertions(+), 4 deletions(-)
google-beta provider	View Diff	2 files changed, 129 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	2 files changed, 3 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
54	43	10	1

Affected Service Packages

• artifactregistry

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccArtifactRegistryRepository_remoteWithAuthUpdate

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccArtifactRegistryRepository_remoteWithAuthUpdate

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047, @Subserial, @trodge VCR tests complete for 5e40bc5!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 16927dd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	2 files changed, 129 insertions(+), 4 deletions(-)
google-beta provider	View Diff	2 files changed, 129 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	2 files changed, 3 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
54	43	10	1

Affected Service Packages

• artifactregistry

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccArtifactRegistryRepository_remoteWithAuthUpdate

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccArtifactRegistryRepository_remoteWithAuthUpdate

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047, @Subserial, @trodge VCR tests complete for 16927dd!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fb277f0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	2 files changed, 129 insertions(+), 4 deletions(-)
google-beta provider	View Diff	2 files changed, 129 insertions(+), 4 deletions(-)
terraform-google-conversion	View Diff	2 files changed, 3 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
54	43	10	1

Affected Service Packages

• artifactregistry

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccArtifactRegistryRepository_remoteWithAuthUpdate

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccArtifactRegistryRepository_remoteWithAuthUpdate

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047, @Subserial, @trodge VCR tests complete for fb277f0!

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[trodge]

The test is failing with

2026-06-09T23:03:40.506Z [ERROR] sdk.helper_resource: Unexpected error: test_working_directory=/tmp/plugintest1153407796 test_name=TestAccArtifactRegistryRepository_remoteWithAuthUpdate test_terraform_path=/usr/bin/terraform
  error=
  | After applying this test step, the non-refresh plan was not empty.
  | stdout:
  | 
  | 
  | Terraform used the selected providers to generate the following execution
  | plan. Resource actions are indicated with the following symbols:
  |   ~ update in-place
  | 
  | Terraform will perform the following actions:
  | 
  |   # google_artifact_registry_repository.my-repo will be updated in-place
  |   ~ resource "google_artifact_registry_repository" "my-repo" {
  |         id                     = "projects/ci-test-project-188019/locations/us-central1/repositories/tf-test-my-repository-pqp8wpyzfm"
  |         name                   = "tf-test-my-repository-pqp8wpyzfm"
  |         # (15 unchanged attributes hidden)
  | 
  |       ~ remote_repository_config {
  |             # (2 unchanged attributes hidden)
  | 
  |           ~ upstream_credentials {
  |               ~ username_password_credentials {
  |                   ~ password_secret_version = "projects/1067888929963/secrets/tf-test-example-secret-pqp8wpyzfm/versions/1" -> "projects/1067888929963/secrets/tf-test-example-secret-pqp8wpyzfm/versions/2"
  |                   ~ username                = "tf-test-username" -> "tf-test-username-new"
  |                 }
  |             }
  | 
  |             # (1 unchanged block hidden)
  |         }
  | 
  |         # (1 unchanged block hidden)
  |     }
  | 
  | Plan: 0 to add, 1 to change, 0 to destroy.
   test_step_number=3

However, I don't see a PATCH request anywhere in the log, so I'm not sure why it's expecting the updated values.