Fix Compute Instance performance monitoring VCR failure

[Capstan]

This PR resolves the TestAccComputeInstance_performanceMonitoringUnit VCR test failure by adding an EmptyOrDefaultStringSuppress("STANDARD") diff suppress function to the performance_monitoring_unit field in advanced_machine_features.

The Compute Engine API recently began returning "STANDARD" as the default value for this field even when it is not explicitly configured, which caused an ImportStateVerify diff mismatch in Terraform.

Fixes hashicorp/terraform-provider-google#24761

Release Note Template for Downstream PRs (will be copied)

compute: fixed a permadiff where `advanced_machine_features.performance_monitoring_unit` would incorrectly show a diff when defaulting to `STANDARD`
container: fixed a permadiff where `node_config.advanced_machine_features.performance_monitoring_unit` would incorrectly show a diff when defaulting to `STANDARD`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 231dbb7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	4 files changed, 23 insertions(+), 19 deletions(-)
google-beta provider	View Diff	4 files changed, 23 insertions(+), 19 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_container_cluster (558 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      advanced_machine_features {
        performance_monitoring_unit = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1761	1647	108	6

Affected Service Packages

• compute
• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceTemplate_performanceMonitoringUnit
• TestAccComputeInstance_performanceMonitoringUnit
• TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
• TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Standard
• TestAccContainerCluster_withLoggingConfig
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerCluster_withAdvancedMachineFeaturesPMU_Standard
❌ Error · Log	-	TestAccComputeInstanceTemplate_performanceMonitoringUnit
❌ Error · Log	-	TestAccComputeInstance_performanceMonitoringUnit
❌ Error · Log	-	TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan VCR tests complete for 231dbb7!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b4eaa08:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	7 files changed, 25 insertions(+), 24 deletions(-)
google-beta provider	View Diff	7 files changed, 25 insertions(+), 24 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_container_cluster (558 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      advanced_machine_features {
        performance_monitoring_unit = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1761	1648	108	5

Affected Service Packages

• compute
• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceTemplate_performanceMonitoringUnit
• TestAccComputeInstance_performanceMonitoringUnit
• TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
• TestAccContainerCluster_withLoggingConfig
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeInstanceTemplate_performanceMonitoringUnit
✅ Log	✅	TestAccComputeInstance_performanceMonitoringUnit
✅ Log	✅	TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan VCR tests complete for b4eaa08!

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8ce500e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	8 files changed, 34 insertions(+), 24 deletions(-)
google-beta provider	View Diff	8 files changed, 34 insertions(+), 24 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_container_cluster (558 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      advanced_machine_features {
        performance_monitoring_unit = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1761	1650	108	3

Affected Service Packages

• compute
• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccContainerCluster_withLoggingConfig
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeRouterPeer_AddMd5AuthenticationKey
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan, @malhotrasagar2212 VCR tests complete for 8ce500e!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0b0b481:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	7 files changed, 25 insertions(+), 24 deletions(-)
google-beta provider	View Diff	7 files changed, 25 insertions(+), 24 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_container_cluster (558 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      advanced_machine_features {
        performance_monitoring_unit = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1761	1651	108	2

Affected Service Packages

• compute
• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccContainerCluster_withLoggingConfig
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan, @malhotrasagar2212 VCR tests complete for 0b0b481!

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[malhotrasagar2212]

Hi @Capstan, Thanks for the PR.
Could you please take a look at the failing VCR tests and missing test report.

[Capstan]

Pull #17889 addressed TestAccContainerCluster_withLoggingConfig; I can sync and re-run.

Draft pull #17890 is trying to address TestAccContainerNodePool_withHostMaintenancePolicy, but is unrelated to this test fix -- it's a persistent stockout problem.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4f38528:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	7 files changed, 25 insertions(+), 24 deletions(-)
google-beta provider	View Diff	7 files changed, 25 insertions(+), 24 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_container_cluster (576 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      advanced_machine_features {
        performance_monitoring_unit = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1787	1676	107	4

Affected Service Packages

• compute
• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstance_performanceMonitoringUnit
• TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
• TestAccContainerCluster_regionalWithNodePool
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeInstance_performanceMonitoringUnit
✅ Log	✅	TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan, @malhotrasagar2212 VCR tests complete for 4f38528!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 94c74a9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	7 files changed, 23 insertions(+), 22 deletions(-)
google-beta provider	View Diff	7 files changed, 23 insertions(+), 22 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_container_cluster (576 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      advanced_machine_features {
        performance_monitoring_unit = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1787	1676	107	4

Affected Service Packages

• compute
• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstance_performanceMonitoringUnit
• TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
• TestAccContainerCluster_regionalWithNodePool
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeInstance_performanceMonitoringUnit
✅ Log	✅	TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan, @malhotrasagar2212 VCR tests complete for 94c74a9!

[Capstan]

TestAccContainerNodePool_withHostMaintenancePolicy's is being tracked in hashicorp/terraform-provider-google#25476, but is persistently failing, and PR #17890 suggests disabling it until quota can be obtained.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 197391f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	7 files changed, 23 insertions(+), 22 deletions(-)
google-beta provider	View Diff	7 files changed, 23 insertions(+), 22 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  advanced_machine_features {
    performance_monitoring_unit = # value needed
  }
}

Resource: google_container_cluster (576 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      advanced_machine_features {
        performance_monitoring_unit = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1787	1678	107	2

Affected Service Packages

• compute
• container

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccContainerCluster_regionalWithNodePool
• TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_regionalWithNodePool
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Capstan, @malhotrasagar2212 VCR tests complete for 197391f!

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[malhotrasagar2212]

The failing tests and missing test report are not due to the added PR changes. LGTM, Thanks