Skip to content

Remove launchStage from readiness_probe examples#17925

Merged
hao-nan-li merged 3 commits into
GoogleCloudPlatform:mainfrom
rafaeltello:readinessprobe
Jun 11, 2026
Merged

Remove launchStage from readiness_probe examples#17925
hao-nan-li merged 3 commits into
GoogleCloudPlatform:mainfrom
rafaeltello:readinessprobe

Conversation

@rafaeltello

@rafaeltello rafaeltello commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

readiness_probe was accidentally created in both google and google-beta. The feature is now GA, so we're just updating the examples to remove the launchStage.

@modular-magician

modular-magician commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bb0323f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 14 deletions(-)
google-beta provider View Diff 4 files changed, 14 deletions(-)
Open in Cloud Shell View Diff 1 file changed, 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
129 109 17 3
Affected Service Packages
  • cloudrun
  • cloudrunv2

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccCloudRunService_cloudRunServiceReadinessProbeExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceReadinessProbesExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceReadinessProbeExample
❌ Error · Log - TestAccCloudRunV2Service_cloudrunv2ServiceReadinessProbesExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@rafaeltello, @kminsu-google VCR tests complete for bb0323f!

@rafaeltello rafaeltello changed the title Promote Cloud Run readiness_probe to GA Remove launchStage from readiness_probe Jun 10, 2026
@rafaeltello rafaeltello changed the title Remove launchStage from readiness_probe Remove launchStage from readiness_probe examples Jun 10, 2026
@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6aa066d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 14 deletions(-)
google-beta provider View Diff 4 files changed, 14 deletions(-)
Open in Cloud Shell View Diff 1 file changed, 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
129 110 17 2
Affected Service Packages
  • cloudrun
  • cloudrunv2

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudRunService_cloudRunServiceReadinessProbeExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceReadinessProbesExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCloudRunService_cloudRunServiceReadinessProbeExample
✅ Log TestAccCloudRunV2Service_cloudrunv2ServiceReadinessProbesExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@rafaeltello, @kminsu-google VCR tests complete for 6aa066d!

@rafaeltello rafaeltello marked this pull request as ready for review June 11, 2026 20:48
@github-actions github-actions Bot requested a review from hao-nan-li June 11, 2026 20:49
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants